Then it crashes here: https://github.com/solidusio/solidus/blob/df51df62fa9b829216958b21b20514b7a3d87b30/core/app/models/spree/order_updater.rb#L175

because one of the line_items is an unsaved / nil

and i can’t figure out who adds that line item

so maybe it’s another line item?

I added a log to see

<http://Rails.logger.info|Rails.logger.info>("add_to_line_item: #{line_item.save!}")

this says true

or some other custom code?

no change when commenting the promo handler

it’s prob some kind of extension that messes with something 🤯

okey, its the subscription extension

i was creating subscription items manually by code after i added the item to the the order. (By calling

SolidusSubscriptions::LineItem.create

). This does something with the order by adding a line item. I guess it could not be saved because i did not pass the item returned by

order.contents.add

to

SolidusSubscriptions::LineItem.create

So on the next loop it crashed. Now the code looks like this:

variants_ids.each do |variant_id|
  variant = ::Spree::Variant.find(variant_id)
  line_item = order.contents.add(variant, 1)
  subscription_line_items << SolidusSubscriptions::LineItem.create({
                                                                     spree_line_item: line_item,
                                                                     quantity: 1,
                                                                     subscribable_id: variant.id,
                                                                     interval_length: 1,
                                                                     interval_units: subscription.billing_period_unit == 'year' ? 'year' : 'month',
                                                                     order: order
                                                                   })
end

The missing line was:

spree_line_item: line_item

in attributes to create