I also don't like that there's code that says: if all the iu's in the shipment are canceled, mark the shipment as shipped. This would be confusing for a customer since they would want to see the shipment as canceled, not potentially on their way: https://github.com/solidusio/solidus/blob/main/core/app/models/spree/order_cancellations.rb#L121