Question Solidus Gurus -- On our website we change...
# supportj
jakemumu
05/18/2023, 9:01 PMQuestion Solidus Gurus -- On our website we change the currency based on customer country, we used to do this via IP lookup and then set a cookie for the user, then we had basically overridden parts of solidus to pull pricing from the session cookie instead of the pricing selectors or the spree config.
We just moved to cloudflare and see we can get the country code with every request for free, so we've change the system to remove all the cookies and instead set
Spree::Config.currencyb
benmorganio
05/18/2023, 11:17 PMI also get the data from Cloudflare, unfortunately traveling abroad or vpn's can make that unreliable.
benmorganio
05/18/2023, 11:17 PMYou could store it somewhere on the browser or a table and let cloudflare prefill it if not already present.
j
jakemumu
05/18/2023, 11:45 PMNice — do you set the currency through the config object as well?
jakemumu
05/18/2023, 11:45 PMOr not using it for currency?
b
benmorganio
05/18/2023, 11:55 PMI'm not actually that far on the MVP!
benmorganio
05/18/2023, 11:57 PMWe store the currency and select based on the CloudFlare data. We also use it to select the region for their games.
benmorganio
05/18/2023, 11:59 PMBut if I were to begin the currency feature right now, I would likely be passing it wherever Solidus has it standardized and then test the checkout from there.
benmorganio
05/19/2023, 12:06 AMAlthough I wouldn't set the config globally on each request. That seems like a bad idea.
benmorganio
05/19/2023, 12:07 AMThere should be a way to check an order out and mark the currency of a line item/order.
j
jakemumu
05/19/2023, 12:07 AMYeah I’m a little confused the right place to set it or if changing the the config is just for the single request or globally changing than and persisted
b
benmorganio
05/19/2023, 12:07 AMMulti currency orders may not be supported by solidus.
benmorganio
05/19/2023, 12:08 AMIf it's the main speed config, that sounds global.
j
jakemumu
05/19/2023, 12:08 AMYeah we don’t want that, the entire site should flip so all the pricing and everything changes on the product pages etc even if they don’t have an order yet
b
benmorganio
05/19/2023, 12:08 AMIt would need a lambda setting to not be global.
j
jakemumu
05/19/2023, 12:09 AMI don’t really get how it could be though unless the config classes are making some sort of local cache on disk or something
b
benmorganio
05/19/2023, 12:10 AMMy app is just going to explicitly state the currency. You checkout in a single currency. Setting the converted price makes me nervous though. Stripe should do the currency exchange for us at the moment they're charged.
j
jakemumu
05/19/2023, 12:11 AMWe’ll it allows you to set the price in multiple currencies which works well
jakemumu
05/19/2023, 12:11 AMSo we send the currency along with the total to stripe & paypal
jakemumu
05/19/2023, 12:12 AMBut how to change the currency is not as clear 😂 before we had a validator which would set the currency on the current order to match the cookie but it still feels like this is in solidus somewhere in a way which isn’t clear to me still
jakemumu
05/19/2023, 12:12 AMThey have the pricing options class but it’s a similar situation
b
benmorganio
05/19/2023, 12:19 AMWell, first up here's where the
Spree::Config.currencybenmorganio
05/19/2023, 12:20 AMSo it's more a
default_currencybenmorganio
05/19/2023, 12:21 AMpricing_options_classbenmorganio
05/19/2023, 12:24 AMI'm already using the pricing options class. I use it to set the line item price equal to the stock item price if the selected stock item has a price associated to it: https://gist.github.com/BenMorganIO/9f457b54c8f224ecc089689e7cabc10f
j
jakemumu
05/19/2023, 12:26 AMThanks so much for that snippet — I’m gonna take another crack at it, I didn’t see how I could switch the pricing option based on the headers with it but there must be a single place I can set the currency for the session 😅
b
benmorganio
05/19/2023, 12:26 AMAnd here's how we use the CF IP on the user: https://gist.github.com/BenMorganIO/76cde5cc819f0541f24c2ec3fbb7d2e5
j
jakemumu
05/19/2023, 12:27 AMOhh nice that’s a really good idea as well
jakemumu
05/19/2023, 12:28 AMI just had to step out maybe when I crack this I’ll through a little blog post up
b
benmorganio
05/19/2023, 12:28 AMAdded the migration.
❤️ 1
j
jakemumu
05/19/2023, 12:29 AMThanks — happy to share some snippets from ours as well, it’s my first time using cloudflare and I gotta say it’s pretty badass what it gives Youn
jakemumu
05/19/2023, 12:29 AMYou*
b
benmorganio
05/19/2023, 12:30 AMYeah, and you don't need to send out a third party request for, well, each request.
j
Jared Norman
05/19/2023, 3:30 AM
Your pricing options class should be using the headers to figure out the currency. Changing it to use the built in extension point is probably pretty trivial, since you only need to change one of the factory methods on the class
Jared Norman
05/19/2023, 3:32 AM
I’d recommend using the built in logic. Your current approach is definitely unnecessarily “outside the box”, since the supported approach is basically just doing the same thing in a different place.
Jared Norman
05/19/2023, 3:35 AM
Also I recommend setting things like country in the session even if you’re inferring them from the CF headers and using that as source of truth so you can provide country switching down the road if need be.