solidus

So the `variant_id` and the `order_id` on `spree_line_items` is `NULL TRUE`. Should we make that `NULL FALSE`? Similarly with all of the `*_total` columns since we have a `0.0` default applied onto them. And the timestamps too.

I’d love to see some of these made more strict. 

<https://github.com/solidusio/solidus/pull/4996>

What about deleted products? Variants are discarded, yes, but still very old stores with a long order history might get in trouble with this migration? Still in favor of more strictness, but this ones seems tricky, no?

We can run a cleanup beforehand or mark the migration as optional/commented out.

Also, if it doesn't work for them, then it would error.

Or they could mark the foreign key constraint as not valid for older data.

All true. Maybe at least document that in the migration? So folks have options?

_probably should comment on the PR_ :grin:

Lol. Yeah. I think NOT VALID is the appropriate solution if they have bad data. An error from their database will likely bring it to their attention.