So the `variant_id` and the `order_id` on `spree_l...
# generalb
benmorganio
03/28/2023, 2:32 AMSo the
variant_idorder_idspree_line_itemsNULL TRUENULL FALSE*_total0.0j
Jared Norman
03/28/2023, 3:15 AM
Iād love to see some of these made more strict.
š 1
b
benmorganio
03/28/2023, 4:48 AMt
tvdeyen
03/28/2023, 6:20 AM
What about deleted products? Variants are discarded, yes, but still very old stores with a long order history might get in trouble with this migration? Still in favor of more strictness, but this ones seems tricky, no?
b
benmorganio
03/28/2023, 6:21 AMWe can run a cleanup beforehand or mark the migration as optional/commented out.
benmorganio
03/28/2023, 6:21 AMAlso, if it doesn't work for them, then it would error.
benmorganio
03/28/2023, 6:21 AMAnd then they can alter the migration.
benmorganio
03/28/2023, 6:22 AMOr they could mark the foreign key constraint as not valid for older data.
t
tvdeyen
03/28/2023, 6:23 AM
All true. Maybe at least document that in the migration? So folks have options?
tvdeyen
03/28/2023, 6:23 AM
probably should comment on the PR š
b
benmorganio
03/28/2023, 6:29 AMLol. Yeah. I think NOT VALID is the appropriate solution if they have bad data. An error from their database will likely bring it to their attention.