I have a cyclic dependency issue, but, I feel like...
# helps
Simon Reilly
09/21/2021, 5:12 PMI have a cyclic dependency issue, but, I feel like the deploy for this would work. Since the cloudformation distribution is created, then the custom resource for the next site replaces the template string. The issue is just that a token for auth node, and a token for site node both need to exist before either takes a dependency on the other. Is there any clever way to bind this?
Simon Reilly
09/21/2021, 5:13 PMCyclic dependency is between site and auth
f
Frank
09/21/2021, 6:47 PM
oh hmm.. thinking..
s
Simon Reilly
09/21/2021, 6:48 PMOh, sorry, fixed with this:
Copy code
const customResourceProps: CognitoCustomResource = {
service: 'CognitoIdentityServiceProvider',
action: 'updateUserPoolClient',
physicalResourceId: PhysicalResourceId.of(
'UniqueIdentityReference-000100'
),
parameters: {
ClientId: String(auth.cognitoUserPoolClient?.userPoolClientId),
UserPoolId: String(auth.cognitoUserPool?.userPoolId),
CallbackURLs: [
`https://${site.cfDistribution.distributionDomainName}/api/auth/callback/cognito`,
],
LogoutURLs: [`https://${site.cfDistribution.distributionDomainName}`],
},
};
// Replace OAuth callback URLs
new AwsCustomResource(this, 'API1', {
onCreate: customResourceProps,
onUpdate: customResourceProps,
policy: AwsCustomResourcePolicy.fromSdkCalls({
resources: AwsCustomResourcePolicy.ANY_RESOURCE,
}),
});Simon Reilly
09/21/2021, 6:48 PMNot the nicest but worked for this use case
f
Frank
09/21/2021, 6:49 PM
Ah through a custom resource to replace the callback urls?
s
Simon Reilly
09/21/2021, 6:49 PMYeah
Simon Reilly
09/21/2021, 6:50 PMNext one is trickier though, need to use the url of the cloudfront distribution in an env var
Simon Reilly
09/21/2021, 6:50 PM Copy code
// Deploy the next JS Site
const site = new sst.NextjsSite(this, 'Site', {
path: 'src/frontend/site',
environment: {
// site ? this ? difficult one
NEXTAUTH_URL: `https://${site.cfDistribution.distributionDomainName}`,
},
});Simon Reilly
09/21/2021, 6:50 PMMaybe needs a callback function that would pass in the construct and allow accessing the internal readonly props
Simon Reilly
09/21/2021, 6:51 PM Copy code
// Deploy the next JS Site
const site = new sst.NextjsSite(this, 'Site', {
path: 'src/frontend/site',
environment: {
// site ? this ? difficult one
NEXTAUTH_URL: (self: Construct) => `https://${self.cfDistribution.distributionDomainName}`,
},
});f
Frank
09/21/2021, 7:20 PM
Oh nice, thats pretty smart đ¤
Frank
09/21/2021, 7:20 PM
Lemme do some quick digging and see if CDK has any recommendations for working around this type of provlems
s
Simon Reilly
09/26/2021, 2:16 PMBumping this one, not sure if you have had any thoughts. Vercel expose the following, which cannot be configured: https://vercel.com/docs/concepts/projects/environment-variables#system-environment-variables
If the custom resource did something similar, where system environment variables could be mapped to custom names, I think that would fit my usecase
f
Frank
09/28/2021, 7:28 PM
Hey @Simon Reilly sorry about slowing getting back to this.
Frank
09/28/2021, 7:29 PM
interesting.. do you mean we can automatically set things like the distribution url as a default environment variable for NextjsSite?
s
Simon Reilly
09/28/2021, 8:02 PMI think that is one option. Vercel allows you to select their system env vars from a drop down and point your own variable name at them.
Simon Reilly
09/28/2021, 8:09 PMI took a look at the NextJSSite construct. Because of the dependency tree it is complex to know the distribution URL of cloudformation, before the deploy of the updated code.
One thought is to do the cfnDistribution deploy, and custom domain, then perform the edge lambda deploy and additional behaviour deploy, so the URL can be known.
Or some kind of second lambda code update, after the distribution is deployed.
There's probably a few options
Simon Reilly
09/30/2021, 7:10 AMI gave this a try, based on the docs touting that you can add behaviours after creation.
Lambda@Edge functions can also be associated with additional behaviors, either at or after Distribution creation time.I got a circular dependency, which to me means, addBehavior is just updating the distribution node, not creating a custom resource that modifies it after deploy âšī¸
f
Frank
09/30/2021, 8:29 AM
Hey Simon, I gave this some thoughts, would this work?
Copy code
const site = new sst.NextjsSite(this, 'Site', {
path: 'src/frontend/site',
environment: {
NEXTAUTH_URL: sst.NextjsSite.DISTRIBUTION_DOMAIN_NAME,
},
});s
Simon Reilly
09/30/2021, 8:31 AMYeah, that would be ace đ
Do you have some implementation ideas? Just curious đ