I think there is an issue with how the current `fileOptions` Serverless Stack #help

I think there is an issue with how the current `fi...

Dan Van Brunt

10/07/2021, 5:25 PM

I think there is an issue with how the current

fileOptions

works in

StaticSite

since

exclude

and

include

are setup as static properties (where includes always override excludes) there is no way to reproduce this command that the s3 sync CLI could…

Copy code

aws s3 sync ./public/ "s3://${BUCKET_NAME}/" \
  --exclude "*" \
  --include "static/*" \
  --include "*.css" \
  --include "*.js" \
  --exclude "sw.js" \
  --cache-control 'public,max-age=31536000,immutable' --delete

Notice the second

exclude

comes after a bunch of includes and another exclude. Perhaps laying out these fileOptions would have been better this way…

Copy code

{
  fileOptions: [
    {
      matching: [
        { exclude: '*' },
        { include: 'static/*' },
        { include: '*.css' },
        { include: '*.js' },
        { exclude: 'sw.js' },
      ],
      cacheControl: 'public,max-age=31536000,immutable',
    },
  ],
}

Dan Van Brunt

10/07/2021, 5:35 PM

or perhaps even shorter something like

Copy code

{
  fileOptions: [
    {
      matching: [ '!*', 'static/*', '*.css', '*.js', '!sw.js'],
      cacheControl: 'public,max-age=31536000,immutable',
    },
  ],
}

Need to check that it doesn’t conflict with other

in standard rules… but it appears you have to use

[!thingy]

if you want to use negate.

Dan Van Brunt

10/07/2021, 5:36 PM

so it could work. you would just strip out the first ! if it exists

Dan Van Brunt

10/07/2021, 5:39 PM

@Frank any thoughts or workaround ideas in the time being? I can’t seem to think of anything unless I add another fileOption group and hope that the uploader script will upload twice and fix the cache the second time?

Dan Van Brunt

10/07/2021, 5:43 PM

Also seems like being able to use ONLY

exclude

is also missing. which is a perfectly acceptable command with the CLI.

Copy code

aws s3 sync ./public/ "s3://${BUCKET_NAME}/" \
  --exclude "*.html" \
  --exclude "page-data/*.json" \
  --exclude "*.js" \
  --exclude "*.css" \
  --exclude "static/*" \
  --exclude "robot.txt" \
  --exclude "sitemap.xml" \
  --delete

Dan Van Brunt

10/07/2021, 5:53 PM

https://github.com/serverless-stack/serverless-stack/issues/903

Frank

10/07/2021, 8:46 PM

Hey @Dan Van Brunt, just read through the thread. Yeah, this makes a ton of sense.

Frank

10/07/2021, 8:46 PM

Just double checking, so the order of `include`s and `exclude`s in the s3 sync command matters right?

Copy code

aws s3 sync ./public/ "s3://${BUCKET_NAME}/" \
  --exclude "*" \
  --include "static/*" \
  --include "*.css" \
  --include "*.js" \
  --exclude "sw.js" \
  --cache-control 'public,max-age=31536000,immutable' --delete

Dan Van Brunt

10/07/2021, 8:50 PM

thats what the docs say…

Dan Van Brunt

10/07/2021, 8:51 PM

To be fair though… I did get it working with the current implementation its just that

sw.js

gets uploaded twice.

Dan Van Brunt

10/07/2021, 8:51 PM

so this could be an issue if someone wanted to do this with more files

Frank

10/07/2021, 9:47 PM

Got it! Yeah, we should definitely respect the order.

Open in Slack

Previous Next