hey guys! (<@U01JVDKASAC> <@U01J5Q8HV5Z> <@U01MV4U...
# helpj
João Pedro
10/10/2021, 8:01 PMhey guys! (@Frank @Jay @thdxr)
1 - I’m making a clear separation between my
dependenciesdevDependenciest
thdxr
10/10/2021, 8:03 PMYes we use esbuild underneath to treeshake. There's actually nothing super special about
dependenciesdevDependenciesthdxr
10/10/2021, 8:03 PMWhat is the dependency you're seeing bundled?
j
João Pedro
10/10/2021, 8:18 PMthe two dependencies are
tsoa@tsoa/runtimeJoão Pedro
10/10/2021, 8:20 PMby definition, devDependencies are only used during development (do not go into the build)
t
thdxr
10/10/2021, 8:21 PMYeah I meant tooling doesn't pay much attention to the difference between the two. So when you inspect the bundle you're seeing
tsoaj
João Pedro
10/10/2021, 8:22 PMyeah - I’m seeing
@tsoa/clitsoaJoão Pedro
10/10/2021, 8:23 PMbut, conceptually speaking, shouldn’t the tooling follow the principle of not deploying
devDependenciest
thdxr
10/10/2021, 8:26 PMIt's up to the user to categorize it so it's not reliable to understand if something is actually referenced. Eg I can add something to devDependency but reference it at runtime and be confused why my bundle is broken in production. Also something can be included in
dependencies Copy code
./node_modules/.bin/esbuild --minify --metafile=meta.json --outfile=output.js --platform=node --bundle ./src/functions/router.tsthdxr
10/10/2021, 8:26 PMThen checking meta.json for
@tsoa/clij
João Pedro
10/10/2021, 8:27 PMsure - I can understand the possible confusion, but by definition, if you reference a devDependency in runtime, that should actually break - it’s a feature, not a bug 😄
t
thdxr
10/10/2021, 8:28 PMYeah this is an npm/node thing. I've always categorized my dependencies intentionally....but it actually does almost nothing so I question why I bother
thdxr
10/10/2021, 8:30 PMOh wow looks like esbuild 0.12.26 has a built in analysis tool
--analyze=verbosethdxr
10/10/2021, 8:30 PMOr can upload here: https://bundle-buddy.com/esbuild
j
João Pedro
10/10/2021, 8:33 PM@thdxr thanks man - I think the meta.json gave me some hints why it’s deploying it with the bundle
João Pedro
10/10/2021, 8:34 PMwould be to large to describe here, but it deals with how typescript and tsoa all ties together
João Pedro
10/10/2021, 8:34 PMthanks!!
João Pedro
10/10/2021, 8:36 PMfor some reason, when I call my lambda, instead of going to the correct handler, it’s calling the
tsoa spec generator Copy code
2021-10-11T08:56:17.709+13:00
Copy
2021-10-10T19:56:17.708Z undefined ERROR Usage: index.js <command> [options]
Commands:
index.js spec Generate OpenAPI spec
index.js swagger Generate OpenAPI spec
index.js routes Generate routes
index.js spec-and-routes Generate OpenAPI spec and routes
index.js swagger-and-routes Generate OpenAPI spec and routes
Options:
--version Show version number [boolean]
--help, -h Show help [boolean]
2021-10-10T19:56:17.708Z undefined ERROR Usage: index.js <command> [options] Commands: index.js spec Generate OpenAPI spec index.js swagger Generate OpenAPI spec index.js routes Generate routes index.js spec-and-routes Generate OpenAPI spec and routes index.js swagger-and-routes Generate OpenAPI spec and routes Options: --version Show version number [boolean] --help, -h Show help [boolean]João Pedro
10/10/2021, 8:37 PMso that’s why I was trying to take that out of my bundle…but now I see I can’t - but at the same time, it shouldn’t call the spec generator, but should call my handler
t
thdxr
10/10/2021, 8:43 PMI actually have a tool that does something similar to TSOA but for JSONAPI and I realized I had a similar issue. Accidentally bundling all the codegen tooling not needed at runtime
j
João Pedro
10/10/2021, 9:28 PM@thdxr anyway to pass different params to esbuild when using sst?
João Pedro
10/10/2021, 9:41 PMoooh this is actually a bug in `tsoa`: https://github.com/lukeautry/tsoa/issues/1069
2 Views