Also, as part of the migration… why are you gettin...
# randoma
Adrián Mouly
05/23/2022, 9:48 PMAlso, as part of the migration… why are you getting rid of enums, in favor of strings?
Copy code
fields: type TableFieldType ⇒ stringt
thdxr
05/23/2022, 9:49 PMin TS there's no reason to use an enum
a
Adrián Mouly
05/23/2022, 9:49 PMIt’s cleaner?
Adrián Mouly
05/23/2022, 9:49 PMYou can get easily who is using the value?
Adrián Mouly
05/23/2022, 9:49 PMEasier to do a refactor?
t
thdxr
05/23/2022, 9:49 PMall of that is still true with a typescript string union
thdxr
05/23/2022, 9:50 PMautocomplete should show you a list of valid options
thdxr
05/23/2022, 9:50 PMthis is true with modern editors whether you're using ts or js
thdxr
05/23/2022, 9:51 PMand the issue with enums is you have to first figure out what to import to even see the options
a
Adrián Mouly
05/23/2022, 9:51 PMThat’s true.
t
thdxr
05/23/2022, 9:53 PMenums were a way to provide pseudo typesafety in JS before TS string unions were a thing
a
Adrián Mouly
05/23/2022, 9:53 PMOk, makes sense.
Adrián Mouly
05/23/2022, 9:53 PMAnd what about Duration… same?
Adrián Mouly
05/23/2022, 9:53 PM😛
t
thdxr
05/23/2022, 9:53 PMCDK uses them heavily because they cross compile into several languages and enums are common in all of them
a
Adrián Mouly
05/23/2022, 9:53 PMI like enums, hate strings 😞
Adrián Mouly
05/23/2022, 9:53 PMWill need to get used to it.
Adrián Mouly
05/23/2022, 9:53 PMYeah.
t
thdxr
05/23/2022, 9:53 PMDuration is a bit interesting, we use something called a template literal type
thdxr
05/23/2022, 9:54 PM Copy code
export declare type Duration = `${number} ${"second" | "seconds" | "minute" | "minutes" | "hour" | "hours" | "day" | "days"}`;thdxr
05/23/2022, 9:54 PMit will only accept "12 seconds" for example
a
Adrián Mouly
05/23/2022, 9:54 PMYeah.
Adrián Mouly
05/23/2022, 9:54 PMI already modified 24 lambdas.
Adrián Mouly
05/23/2022, 9:54 PMHahaha.
t
thdxr
05/23/2022, 9:54 PMhaha oh
a
Adrián Mouly
05/23/2022, 9:54 PMActually, more.
t
thdxr
05/23/2022, 9:55 PMthis one is a bit worse because TS autocomplete doesn't do a great job when there's a dynamic part of a string template
thdxr
05/23/2022, 9:55 PMbut I imagine this will get better