Hi, I opened this PR <github.com/puppetlabs/ruby-p...
# puppet
c
Hi, I opened this PR github.com/puppetlabs/ruby-pwsh/pull/384 to fix an issue related to string nullification. It was fixed in 2024 but the last commit made this happen again
j
Thank you! Are you able to update the PR to point to the commit that reverted the scenario? It feels like we need a test in here to catch this from getting reverted again. Is that in the PR you added?
c
Hi @Jason St-Cyr, I updated first comment. I also handled specs to properly test empty string, empty array and empty hash
celebrate 1
FYI, i'm also working on another old issue github.com/puppetlabs/ruby-pwsh/issues/327 I will probably make a PR after the current one has been settled (this is the WIP code github.com/puppetlabs/ruby-pwsh/compare/main...Clebam:ruby-pwsh:fix_array_of_hashes_comparison, which seems to work.)
j
Thanks for taking a look at these @clement.le.roux496!