https://www.puppet.com/community logo
Join Slack
Powered by
This message was deleted.
# voxpupuli
s
This message was deleted.
a
I am the original maintainer, and I can't really maintain it, myself; that said, I do actually have word from one of the people who submitted a PR that they'd be willing to maintain it; their exact words were
transfering it to vox-pupuli should indeed be the best option.
If they are not interested, I can probably take over
So, I'm not 100% certain, but, they'd probably be willing to assist in maintaining it with Vox Pupuli
b
ah nice
a
They're in this Slack (at least, they're registered to it, I don't know if they regularly use it): @johan care to comment?
According to their Slack profile, it's 9:44PM in their local time zone, so they may not see this until tomorrow.
b
let's see what @johan says tomorrow
a
👍
In case he doesn't respond here, I'll mention this thread in the PR he opened, as well
👍 1
j
And here I am, indeed been a while since I popped in here 🙂
@bastelfreak Since we are actively using this module, I can be its 'mentor'. If there are some things I need to read/learn, i'm sure you will direct me
b
sounds good to me. @adam.gardner I invited you yesterday to our github org. when you accept it you should be able to migrate the module
@johan what's your github handle?
j
witjoh
👍 1
and joined
👍 1
b
we've some review guidelines at https://voxpupuli.org/docs/reviewing_pr/, most stuff is fine unless you merge your own PRs' that aren't approved by someone else, if you've any questions just ask here or on IRC (the rooms are bridged through our bot)
a
Just popping in to say, I'll accept the invite and begin the transfer process on US Sunday
👍 1
Invitation accepted and repository ownership transfered
👍 2
Happy to be passing the torch to @johan, I felt a bit bad about not being able to properly maintain it myself.
@bastelfreak @johan If it's the same to you guys, I'm going to leave handling the PRs for e.g. 
modulesysnc
stuff to you two.
👍 2
There's also a fair amount of junk in there that exists explicitly to preserve Puppet 5 compatibility, which you'll probably want to remove. IIRC it's pretty clearly demarcated with comments.
b
yeah we're going to puppet 7 as minimal version
a
(I mean, it'll still work if you leave it there, but it just becomes needless cruft)
I guess it's not really that much ("fair amount" is stretching it), it's a single method definition and all of the calls to it, for handling this weird puppet-5 inconsistency between 
puppet agent
and 
puppet apply
with the way 
undef
and 
nil
were handled: https://github.com/voxpupuli/puppet-graylog_api/blob/main/lib/puppet/provider/graylog_api.rb#LL113C1-L126C8
Open in Slack
PreviousNext
Powered by