https://www.prisma.io/ logo
Join Slack
Powered by
# orm-help
  • c

    CCBCodeMonkey

    02/21/2019, 7:36 PM
    https://github.com/prisma/prisma/issues/1263
  • d

    dan

    02/21/2019, 7:36 PM
    All our deployments are automated with circle and clusters
  • c

    CCBCodeMonkey

    02/21/2019, 7:36 PM
    yea for me I just do a checkin with the first schema, and a checkin with the next schema
  • c

    CCBCodeMonkey

    02/21/2019, 7:37 PM
    it is something they should fix
  • d

    dan

    02/21/2019, 7:37 PM
    Like any other framework, the default value would be set when adding the field 🙄
  • c

    CCBCodeMonkey

    02/21/2019, 7:37 PM
    I do validations on top of prisma anyways when I save data
  • c

    CCBCodeMonkey

    02/21/2019, 7:37 PM
    so the whole required field isn't a huge deal for me
  • c

    CCBCodeMonkey

    02/21/2019, 7:37 PM
    they could use a whole lot more stuff around validations
  • d

    dan

    02/21/2019, 7:38 PM
    The reason you make it required is for the generated graphql schema and client
  • d

    dan

    02/21/2019, 7:39 PM
    Ugh, this is not just a bug, its a flaw
  • d

    dan

    02/21/2019, 7:40 PM
    If a field is required, it should also require a default value, problem solved.
  • c

    CCBCodeMonkey

    02/21/2019, 7:44 PM
    no? I could see having a required field without a default value
  • c

    CCBCodeMonkey

    02/21/2019, 7:44 PM
    that would mean whatever is inserting the data would have to make sure that field is there or it fails to insert
  • c

    CCBCodeMonkey

    02/21/2019, 7:45 PM
    you are saying, adding required to data with existing rows would require a default value, then yes I agree with that
  • c

    CCBCodeMonkey

    02/21/2019, 7:45 PM
    Copy code
    The reason you make it required is for the generated graphql schema and client
    how is this different than what I said? required fields to me are basically a simple validation on the data
  • c

    CCBCodeMonkey

    02/21/2019, 7:46 PM
    I do a lot more complex validations past just required
  • c

    CCBCodeMonkey

    02/21/2019, 7:46 PM
    ie string length, alphanumeric, blah blah
  • c

    CCBCodeMonkey

    02/21/2019, 7:47 PM
    again I am not on the prisma team so you should open an issue or comment with them, I think this is is an issue but not as impactful as your are saying it is
  • c

    CCBCodeMonkey

    02/21/2019, 7:47 PM
    there is a lot of stuff I would like to see first
  • d

    dan

    02/21/2019, 7:49 PM
    super frustrating that I cant just deploy once
  • d

    dan

    02/21/2019, 7:49 PM
    and run migrations
  • c

    CCBCodeMonkey

    02/21/2019, 7:50 PM
    then switch I guess, I would guess you would find some frustrating issues on pretty much any backend
  • c

    CCBCodeMonkey

    02/21/2019, 7:50 PM
    in terms of level of frustration, that sounds like a 2 to me out of 10
  • c

    CCBCodeMonkey

    02/21/2019, 7:50 PM
    compared to other issues I have run into with prisma
  • c

    CCBCodeMonkey

    02/21/2019, 7:50 PM
    like for example, not being able to have multiple order bys
  • c

    CCBCodeMonkey

    02/21/2019, 7:51 PM
    https://github.com/prisma/prisma/issues/62 which I think is way more impactful
  • c

    CCBCodeMonkey

    02/21/2019, 7:51 PM
    or not being able to add fragments on prisma bindings
  • c

    CCBCodeMonkey

    02/21/2019, 7:51 PM
    those are the biggest things i'd like to see
  • c

    CCBCodeMonkey

    02/21/2019, 7:52 PM
    or ordering by sub fields
  • c

    CCBCodeMonkey

    02/21/2019, 7:53 PM
    or being able to extend your schema in your apollo server layer(which works but is hacky)
1...216217218...637Latest