This message was deleted.
# ask-anythings
Slackbot
09/19/2022, 4:10 PMThis message was deleted.
b
Brandon Williams
09/19/2022, 4:17 PMw
Willie Wheeler
09/19/2022, 4:18 PMPerfect, thanks very much!
🙇 1
Willie Wheeler
09/19/2022, 4:19 PMOh lol, just noticed the “doesn't work on Windows” part 🤣
🙃 1
🤣 1
Willie Wheeler
09/19/2022, 4:19 PMStill good to know that this is the direction of the solution
e
Eduardo
09/19/2022, 4:29 PM
@Willie Wheeler: I remember implementing the git hook and seeing some errors on github actions on windows but not locally. you might still wanna give it a try. if you encounter issues, let us know!
w
Willie Wheeler
09/19/2022, 4:48 PMOk great — I’ll do that and report back either way
Willie Wheeler
09/19/2022, 5:50 PMI see what the errors are. Git is using Unix the path separator to invoke the hooks (resulting in path not found) and anyway the hooks are bash scripts. It seems I may be able to use WSL (Windows Subsystem for Linux) to overcome this. If so I’ll write it up and submit a docs PR
🙏 2
e
Eduardo
09/19/2022, 11:08 PM
awesome, thanks!
w
Willie Wheeler
09/26/2022, 11:09 PMI finally got around to trying this on Linux. One issue I’m having is that my repo has multiple projects, each with its own virtual env. So the virtual env is not at the same level as the .git dir. When I do the hook injection, ploomber wants me to run that from the top level. But when I commit, the hook can’t find ploomber because it’s a level in
Willie Wheeler
09/26/2022, 11:09 PMI can just manually remove the injected params with the —remove option but thought I’d mention this in case others run into it
b
Brandon Williams
09/27/2022, 8:39 AMw
Willie Wheeler
09/27/2022, 5:30 PMthanks. yep.
🙌 1
e
Eduardo
09/28/2022, 12:09 AM
thanks for your feedback! we'll add this to our backlog 🙂
2 Views