This message was deleted.
# ask-anything
s
This message was deleted.
e
you're right! it's a problem on our end. papermill was an optional dependency but now it's mandatory, so we should move it in the setup.py. PRs welcome!
r
I would like the opportunity to try to submit this PR. Seems like is straight forward. I guess just changing it to REQUIRES should work. What do you think?
e
yep. another thing to ensure this wont' happen is to update the CI configuration file: instead of simply installing dev dependencies, do:
Copy code
pip install .
python -c "import soorgeon"
pip install ".[dev]"
this will ensure that if we only install mandatory dependencies,
import soorgeon
works without problems
because right now, we install dev dependencies and then test. that's why we didn't notice this error
r
Oh, thanks. I will try to submit a PR with that.
🙌 1
Done. Let me know if I did something wrong. https://github.com/ploomber/soorgeon/pull/86
@Eduardo would it be a good idea for me to work this week on apply black before refactoring ? Maybe I could figure it out.
e
sure, give it a try!
r
@Eduardo I posted how got it working in the issue but hope u can take a look at it before submitting a PR because I might be missing something.
e
thanks! I'll take a look in the next few days