https://pact.io logo
Join Slack
Powered by
I'm just trying to think of what's outstanding for...
# pact-net
a
I'm just trying to think of what's outstanding for 
4.0.0-beta.1
and I can't think of much. I'm not sure if any of them are particularly blockers, but still to do off the top of my head: • GitHub Action for publishing to NuGet when you create a tag (easy, 10mins work) • A new FFI version with 
reqwest
updated to fix the panic related to invalid certificates ◦ I'm not sure this is a blocker for a beta, but it totally breaks on my machine and I imagine others will have the same problem. I think it's a blocker for a proper release though because it literally just crashes and there's no real way to work around it. • I'm not quite sure where messaging pacts are up to, but if they do work then we definitely don't have any documentation for them. I'm not entirely sure they're finished at the moment though ◦ Again, I don't think this is a blocker as there would be no breaking API changes for request/response interactions So I think what I'm saying is the only thing needed for a beta is writing the GitHub Action.... 😮 I'll do that now
🙌 1
m
I wouldn’t block the beta release because of the above, but certainly agree for mainline
With events, my view would be getting it into the hands of the community (even in main) wouldn’t be a bad thing, because they currently don’t have it now anyway (even if undocumented)
Obviously, we’d want the documentation to follow, hopefully when Yann is back he can contribute that with his deeper knowledge of it all
Documentation for new matchers would probably help as well
l
I'm so excited for this release 😄
Thanks so much for your hard work!
❤️ 2
a
OK I've merged the CI changes to trigger a nuget.org release. I think we go for a beta 1 now 😮 Thoughts?
❤️ 2
Might be worth merging the 
feature/4.0.0
branch to 
master
if we do a release, otherwise people will turn up at the repo and be very confused 😄
m
Yes, I was going to suggest the master branch should be forked into a 3.x.x in case of patches etc.
and then a note in the main README about the two versions
a
I've created a 
release/3.x
branch which is just pointing at current 
master
👍 1
Can we un-protect the 
feature/4.0.0
branch so that I can push up the merge from 
master
, then I can raise the PR to merge that back into 
master
(because there are merge conflicts)
👍 1
m
Wondering if we should merge it into master, or simply replace master (and then branch 3.x.x from master and have a separate line)?
Happy either way
Gimme a few hours, just looking it line by line…………
a
Hmmmm yeah, we could just 
git reset --hard origin/feature/4.0.0
now that there's a 
release/3.x
branch pointing at the head of where 
master
is now. It would all be easier if 
master
hadn't moved to fix that cert thing 😄
Technically that's a bad thing to do because 
master
will 'lose' commits, so if people have forked it then they may get in a mess. I think maybe we stick with the merge, although it makes the history a bit messier, but just because it's the 'right' thing to do. It's either that or rebase the entire 4.x branch onto latest 
master
and that sounds even worse
👍 1
Open in Slack
PreviousNext
Powered by