Hey :wave: Just a quick question: I found a test ...
# proj-agent
m
Hey 👋 Just a quick question: I found a test script at
openhands-sdk/sdk/test/test_acp_dedup_and_truncation.py
. Here, this script will never be triggered by the CI, since we are running
pytest tests/sdk
. Was this intentional, or is it just a rebase error? If it was unintentional, I moved it in the correct location -> https://github.com/OpenHands/software-agent-sdk/pull/3064
c
ugh i thought i had a CI to enforce this 😅
it is definitely an error
pushed a fix to the CI
m
Instead of using a regex, could we not use
pytest --collect-only
it is fast (just collection) and we have already pytest installed. The command collect all the tests that pytest will run, and if a test is in the wrong place it will be detected. I think it is a bit more robust. I can also open a different PR for that