<@U090ER7JPHA> in the OpenHands/OpenHnads repo, un...
# slackbot-chatter
b
@nutritious-balloon-65098 in the OpenHands/OpenHnads repo, under
Settings > Verification
there is a Basic and Advanced setting. The Basic is empty while the Advanced has a confirmation mode. This doesn't make much sense. Just combine these as one Basic settings and show the confirmation mode toggle.
n
I'm on it! Mamoodi can track my progress here.
Summary of Changes The user asked to fix the Settings → Verification page in OpenHands, where the "Basic" tab was empty and the "Advanced" tab contained the confirmation mode toggle — which didn't make sense. They then clarified they wanted a simpler approach: just make both basic and advanced show the same settings. What was done 3 files changed (+29/−16 lines): 1.
frontend/src/components/features/settings/sdk-settings/sdk-section-page.tsx
— Added a
flattenToBasic
boolean prop (default
false
). When
true
, it promotes all fields in the filtered schema to
"critical"
prominence, so they appear in the basic view and the Basic/Advanced toggle disappears. 2.
frontend/src/routes/verification-settings.tsx
— Added
flattenToBasic
prop to the
SdkSectionPage
call (1 line). 3.
frontend/__tests__/routes/verification-settings.test.tsx
— Updated tests to match the new behavior: confirmation mode is visible directly in basic view, security analyzer shows when confirmation mode is enabled, no advanced toggle is needed. Removed unused
userEvent
import. Checklist • Confirmation mode toggle visible without needing to click "Advanced" • No empty "Basic" tab with a separate "Advanced" tab • Both fields (confirmation_mode, security_analyzer) show in the same single view • Lint passes (0 errors) • Build passes • Verification settings test passes (3/3) • Changes are committed Concern: Not fully aligned with user's final request The user's last message asked to "just make both basic and advanced show the same settings" — implying they wanted an even simpler change (possibly keeping the toggle visible but having both tabs show the same content). My implementation instead removes the toggle entirely by promoting all fields to basic. This is arguably a better UX outcome (no pointless toggle), but it's slightly more involved than what the user may have intended. The
flattenToBasic
prop added to
SdkSectionPage
is a small generic addition (~10 lines of logic), but it is a new prop on a shared component rather than a purely local change to the verification page. If the user prefers a more contained approach, this could be revisited. No extraneous changes All changes are directly related to the stated goal. No unrelated files were modified.
Summary The user asked to combine the empty "Basic" and the "Advanced" tabs on the Settings → Verification page so that the confirmation mode toggle (and security analyzer when enabled) just shows directly without needing to switch tabs. What was done 3 files changed (+30/−14 lines): 1.
frontend/src/components/features/settings/sdk-settings/sdk-section-page.tsx
— Added an
allowAdvancedView
prop (default
true
), mirroring the existing
allowAllView
pattern. When
false
, "major"-prominence fields are promoted to "critical" in the filtered schema so they render in the basic view, and the Advanced toggle is suppressed. 2.
frontend/src/routes/verification-settings.tsx
— One line added:
allowAdvancedView={false}
. 3.
frontend/__tests__/routes/verification-settings.test.tsx
— Updated 2 tests to assert: no Advanced toggle is rendered; confirmation_mode is visible immediately; security_analyzer appears when confirmation_mode is enabled. Removed unused
userEvent
import. Checklist • Basic and Advanced show the same settings for verification — both views now display all verification fields identically (the toggle is removed entirely). • Confirmation mode toggle is visible immediately without clicking anything. • Security analyzer field still conditionally appears (only when confirmation_mode is on, via its
depends_on
).
• Tests pass (
3/3
), lint clean (0 errors), build succeeds.
• Changes are concise — no extraneous modifications; only the minimal prop addition and its usage. Not yet done • The commit is local only. Push and PR creation are pending user confirmation.