<@U06QJHRBLQG> I think this PR is failing checks o...
# proj-agent-canvas
q
@chilly-france-44439 I think this PR is failing checks on main, blocking other PRs: https://github.com/OpenHands/OpenHands/commit/00daaa41d327435f61a7e93e70debfa8d75f8650
✅ 1
c
ugh sorry! @nutritious-balloon-65098 can you send another PR that fixes the workflow? https://github.com/OpenHands/OpenHands/actions/runs/23155605511/job/67269357827
np 1
n
I'm on it! Xingyao Wang can track my progress here.
Here's a summary of what was done: Problem: Commit
00daaa41d
(PR #12773 — "Load workspace hooks for V1 conversations") was merged to
main
with a broken test class
TestLoadHooksFromWorkspace
in
tests/unit/app_server/test_live_status_app_conversation_service.py
. All 9 tests in that class failed with:
Copy code
TypeError: LiveStatusAppConversationService.__init__() missing 2 required positional arguments: 'pending_message_service' and 'max_num_conversations_per_sandbox'
Fix: Added the two missing constructor parameters to `TestLoadHooksFromWorkspace.setup_method()`: -
pending_message_service=self.mock_pending_message_service
(with a new
Mock()
instance) -
max_num_conversations_per_sandbox=20
This matches the exact pattern already used by the other two test classes in the same file. Verification: All 9 previously failing tests pass locally. Status: - ✅ Changes already pushed to branch
fix/test-missing-init-params
- ✅ PR created: https://github.com/OpenHands/OpenHands/pull/13424 - ✅ Only 1 file changed, 3 lines added — minimal and focused fix - ✅ No extraneous changes
c
@quick-window-91705 this should hopefully fix it https://github.com/OpenHands/OpenHands/pull/13424
q
Thanks!