Looking for second review on a large raredisease m...
# release-review-trading
r
Looking for second review on a large raredisease major 4.0.0 github.com/nf-core/raredisease/pull/1059. Happy to trade. 😄
approved with comments 1
421 files changed, but most are mechanical or supporting changes. Here’s a suggested review breakdown: Skippable / low-priority review: 303 files • 107
modules/nf-core/**
for version/container bumps • 13
subworkflows/nf-core/**
for version bumps • 23 template/CI files • 37 pipeline-level tests and test configs • 123 local subworkflow/module test files, snapshots and fixtures Key files for review: 118 files • 44
subworkflows/local/**/main.nf
for subworkflow logic • 26
conf/modules/*.config
for configuration wiring • 8
modules/local/**
for new/changed local modules •
<http://main.nf|main.nf>
+
workflows/raredisease.nf
for core workflow wiring • 2
nextflow.config
files and
nextflow_schema.json
• ~10 documentation and asset/config files • ~6 images, README, CHANGELOG and CITATIONS
d
Will you look at github.com/nf-core/magmap/pull/289 in return? Much smaller, just a patch release.
r
Sure! I'll take a look now 🙂
@Daniel Lundin I've addressed your comments in github.com/nf-core/raredisease/pull/1062 🙏