Any wave-experts out there that could increase my ...
# pipeline-maintainers
j
Any wave-experts out there that could increase my confidence in merging this github.com/nf-core/epitopeprediction/pull/338?
p
Huh, interesting approach! This is because we can't even host custom containers on our quay.io ?
r
what is the issue with wave?
p
No issue, it's just on-demand with wave only.
In the past we've said that people should make and supply their own docker images in such cases. This is arguably a more user friendly and nicer approach.
keanu thanks 1
💯 1
j
Yeah the licence of the tool specifically states that software is not allowed to be deployed permanently somewhere, therefore I thought wave is the best solution
👍🏻 1
Thanks for the quick feedback!
r
now I get it. In the past for other things like module bins we said no to having wave as a dependency. I think it makes sense here though. Could probably add that if someone doesn't want to use wave/has access to it, that they need to supply their own containers
👍🏻 1
👍 1
m
My concern is reproducibility. They'll never get the same image given it has
apt-get update
etc, but practically it might be a non-issue if enough of what the tool is pinned ( I see most things I think that are important are pinned though ).
👍 1