Hi all, I'm coming back from paternity leave, and I'm reviewing a PR I had started to update nf-core modules (PR #448). Along the way, I discovered a bad code smell that I think should be a new issue:

modules/local/multiqc.nf

is pinned to MultiQC 1.13, but the

nf-core multiqc

module is installed and tracked in

modules.json.

And from what I can tell, the latter is totally unused. Module updates and template syncs keep bumping it (to 1.35 in PR #455 for example), which makes it look as if the pipeline uses a newer MultiQC than it does. This should be a new issue, right? With the solution being to remove

modules/local/multiqc.nf

in favor of

modules/nf-core/multiqc

?

Congratulations! Yes open it as a new issue, your PR is already massive 😉 Btw during your absence we opened a new #C0C30LAV0G7 channel to discuss the development related things

joined!