I am wondering why there are silent mishaps (i.e. ...
# nf-test
d
I am wondering why there are silent mishaps (i.e. not failing test) in the nf-test output in nf-core/ampliseq: (1) in github.com/nf-core/ampliseq/…/98098280400?pr=1062
Copy code
> -[nf-core/ampliseq] Pipeline completed successfully-
      PASSED (785.039s)
    Snapshots:
      Obsolete snapshots can only be checked if all tests of a file are executed successful.
(2) in e.g. (not the origin, because I didnt find it earlier) github.com/nf-core/ampliseq/…/98194283276?pr=1065:
Copy code
> -[nf-core/ampliseq] Pipeline completed successfully-
  Error reading YAML file: /home/runner/_work/ampliseq/ampliseq/~/tests/a29655bff5567c226ec88c6ed9d3de74/output/pipeline_info/software_versions.yml (No such file or directory)
      PASSED (306.768s)
I would hope that those issues lead to failing tests, or are those unimportant? Maybe something went wrong here with the pipeline, nf-test, or such?
👀 1
m
filename is wrong
it should be nf_core_ampliseq_software_mqc_versions.yml
d
Yes, indeed. But the main issue is: why does that lead to a passing test? Why isnt that test failing? I think it should fail, shouldnt it?
m
first time you launch the test it tries to read the yaml file, which doesn't exist, do nothing from there is captured
But I see your point with the failure
maybe we can be stricter here
could you create an issue in the nft-utils repo
👍 1
thanks to @Louis Le Nézet we are now in a fast release cycle
d