https://nf-co.re logo
Join Slack
Powered by
Hi all! I still need 2 reviews for the first relea...
# release-review-trading
l
Hi all! I still need 2 reviews for the first release PR of nf-core/hadge. Happy to trade a review! github.com/nf-core/hadge/pull/115
👀 1
s
Hi! Impressive work for the pipeline! I made a first round a review and requested some updates. Do not hesitate if you have any questions. (I have a review pending too If you are OK to trade github.com/nf-core/isoseq/pull/62)
l
Thank you very much for the feedback, @Sébastien Guizard! Try to give you a review soon 🙂
@Daniel Lundin already gave you a review one hour ago. In this case, I think you already have enough reviews, @Sébastien Guizard. If that's not the case, let me know.
s
Yeah 2 is already enough work xD Thanks for proposing. I see you started to work on the review. Do not hesitate to ask for help if you need 😉 The part on multiQC might be the trickiest. It's a lot of work to develop the multiQC modules :/ Maybe it can be discussed with the core team.
l
Great, thank you! I'll work my way through your review and let you know if I have any questions. 🙏
👍 1
The first review round is done! Now I need a review from <!subteam^S016E36N7TQ> or <!subteam^S044DU0NG68>, as this is the first release PR for nf-core/hadge. Could someone help me out?
d
I can have a look; I'm part of <!subteam^S044DU0NG68> since last week. Are you sure you don't need one from <!subteam^S016E36N7TQ>? I'm preparing a minor release of #C04NLA7QHH9 that you could check in return.
s
This proposition comes from me, I suggested that core team / maintainers might help to determine the level of information the multiQC report should contain. Maybe you can advise on that point?
d
Me? Which proposition? (I have a poor history with MultiQC in my pipelines; trying to become better.)
s
The same for me xD. For now the multiQC report is empty. I guess it needs a minimum content?
d
People seem to use this, so the more the merrier. I'm an R person so I've had everything in tsv tables, but I've copied a lot to MultiQC now in terms of overall statistics etc.
multiqc 1
@Luis Heinzlmeier: My phyloplace minor release is now open for review: github.com/nf-core/phyloplace/pull/100 (PR 100, 99 changed files.)
✅ 1
Actually, perhaps you never agreed on the trade? In any case, if you want to have a look I'd be grateful.
l
Sorry for the slightly delayed replies, I have to submit my thesis soon :D Thank you for the review, @Daniel Lundin! I'll return the favor and review your PR as soon as possible (hopefully by the end of this week). I mainly pinged the core and maintainers teams because it's listed as a requirement for the first release.
d
Phyloplace was released today, so you're off the hook there. I asked @Sébastien Guizard who contributed one review of phyloplace to look at metatdenovo 2.0 (github.com/nf-core/metatdenovo/pull/540) -- a much larger beast; I couldn't do it without agent support -- so if you want to take on that I'd be grateful of course.
👍 1
✅ 1
l
Thank you, @Sébastien Guizard and @Daniel Lundin! Added all our review comments. All tests pass. If we're ready to merge, I'd appreciate it if you could approve the PR. 🚀
d
Done!
Congratulations to your release -- good work!
gratitude thank you 1
l
<!subteam^S016E36N7TQ>, could you please remove the “Block releases” GitHub repository ruleset?
👀 1
m
@Luis Heinzlmeier have you had a review from a core member?
l
Hi @Maxime Garcia! The release procedure says > Request one review from one core or maintainers team member I received a review from @Daniel Lundin, who is a member of the maintainer's team: https://nfcore.slack.com/archives/C08K66XCZSL/p1790015254813329?thread_ts=1789638950.698729&cid=C08K66XCZSL Is this enough, or do I need another review from a core member?
j
m
@Luis Heinzlmeier I am checking with other members, you'll have a reply ASAP, sorry for the delay
gratitude thank you 1
My only concern, minimal and non blocking, would be that you are not linking the zenodo DOI in the README -> https://doi.org/10.5281/zenodo.10634731 but that can be fixed in future releases/PRs.
You're good to go, I'll unblock you
sorry for the delay
l
Thank you, @Maxime Garcia! Created an issue to link the Zenodo DOI in the next release. Please let me know if there's anything else I need to do at this point.
m
I think we're good
gratitude thank you 1
Open in Slack
PreviousNext
Powered by