Can I get a reviewer for genomeqc's patch release ...
# release-review-trading
f
Can I get a reviewer for genomeqc's patch release please? It's a fairly simple one, mainly a couple of module updates github.com/nf-core/genomeqc/pull/298
✅ 1
d
Happy to trade with my patch release: github.com/nf-core/metatdenovo/pull/515. If you can have a look at the corresponding module fix too would be great: github.com/nf-core/modules/pull/12934
Your tests aren't passing, so I'll hold off for a while.
f
Thanks! I'll have a look at your PR later. Our tests were failing due to a server issue, but it's solved now
d
The pipeline already got two, but one was on another PR than the current, only difference being the first was my fork, the new was the nf-core upstream. Unfortunately, the person who gave me that seems to be busy, so if you can just give this your approval I'd be grateful: github.com/nf-core/metatdenovo/pull/517 It is actually only a one-liner plus CHANGELOG and boilerplate. (The module I mention above is already approved and merged.) I'll look at yours during the afternoon (CET).
f
Done!
keanu thanks 1
d
Just approved yours, with one tiny comment.
extreme teamwork 1