OK, who wants to trade with me for a <#C05785S3TMX...
# release-review-tradingj
Jonathan Manning
09/14/2026, 10:54 AMOK, who wants to trade with me for a #C05785S3TMX release review? github.com/nf-core/riboseq/pull/234
I will admit that it's fairly chunky...
👀 2
m
Maxime Garcia
09/14/2026, 11:41 AM#C024915L4KB in exchange?
Maxime Garcia
09/14/2026, 11:41 AMI am needing a second set of eyes
j
Jonathan Manning
09/14/2026, 11:42 AMSure! Think you're getting a raw deal 😄 . Will get to it after lunch
m
Maxime Garcia
09/14/2026, 11:42 AMI have a #CL88J906S soon too if you want more 😆
😆 1
j
Joon Klaps
09/14/2026, 1:20 PM@Jonathan Manning trade for #C0905QCFTPE? 😄
✏️ 1
j
Jonathan Manning
09/14/2026, 1:26 PMSure!
@Maxime Garcia You have my tick on fetchngs, didn't have anything extra on top of the feedback you already have
🎉 1
Jonathan Manning
09/14/2026, 2:32 PM@Joon Klaps left you some minor notes
❤️ 1
Jonathan Manning
09/14/2026, 4:55 PM@Joon Klaps thanks for your helpful review- points addressed here: github.com/nf-core/riboseq/pull/237
Jonathan Manning
09/15/2026, 9:15 AM@Joon Klaps the 237 with your fixes merged, 234 still passing. Could I get your approval?
m
Maxime Garcia
09/15/2026, 9:18 AMSorry, I got distracted, I'm back at it
thankyou 1
Maxime Garcia
09/15/2026, 9:23 AMI only have one concern, I can see in your modules.config that you seem to have some publishDir for the versions.yml file, but I have a feeling that this pipeline has already quite progressed towards topic
j
Jonathan Manning
09/15/2026, 9:23 AMlet me check...
Jonathan Manning
09/15/2026, 9:37 AMHere you go: github.com/nf-core/riboseq/pull/238
m
Maxime Garcia
09/15/2026, 9:38 AMTHANKS
Maxime Garcia
09/15/2026, 9:38 AMthat was bugging me
j
Jonathan Manning
09/15/2026, 10:58 AMother nitpicks addressed: github.com/nf-core/riboseq/pull/239
👀 1
Jonathan Manning
09/15/2026, 1:28 PMFinal tests running, all ready to go when @Joon Klaps approves
Jonathan Manning
09/15/2026, 5:08 PMThanks guys! Release out!
Post-release bumps: github.com/nf-core/riboseq/pull/240
✅ 1
2 Views