Hello friends, We found that many nf-core subwork...
# team-maintainers
b
Hello friends, We found that many nf-core subworkflows have inconsistencies in inputs/outputs between the
<http://main.nf|main.nf>
and
meta.yml
. This came up because we are building the auto-import of nf-core subworkflows into the Nextflow registry and we want to make sure the module specs are correct PR: github.com/nf-core/modules/pull/12882 It is ready from my end but I understand that modules are typically updated one at a time. Let me know how you want to handle these fixes. I can split into ~100 PRs if you want 😅 cc @Jonathan Manning
👌 1
k
Please no to the 100+ PRs. Let's merge it in a block.
m
I think the bigger question from our side is how did this get past linting? The linting should check these are consistent
Looking over some of those in the PR, they're just entry swaps. Why does that matter?
s
The subworkflows haven't been linting properly (or at all?)
m
ah, true
s
The modules ones are mostly just reordering
b
yeah I wasn't sure whether to include the process output reordering. I think my agent did that to make it "consistent" with the source code but it doesn't really matter. I can revert that part if you want
m
split it into two PR's I think
s
the reordering is fine
I'd like to see that the nf-core modules lint passes for the modules
but I'm confused as to why nf-test even ran here
maybe it was the one change to a main.nf
This PR: github.com/nf-core/modules/pull/12581 only updated meta.yml files and didn't run nf-test at all (correctly)
I'm making a PR for pygenprop (including fixing the linting)
github.com/nf-core/modules/pull/12887 if anyone wants to tick that
✅ 1
Then I'm hoping that nf-test won't run at all
Which it didn't merge queue
b
Thanks Simon!
🙌 1
s
No problem, thanks for doing the hard work, I just try and get things merged 😉