https://nf-co.re logo
Join Slack
Powered by
I have a problem with my module's tests, the tests...
# nostupidquestions
l
I have a problem with my module's tests, the tests pass, the snapshot is stable, but nf-test still fails with
Copy code
Displaying nf-test error
CRITICAL Ran, but found errors:
          - nf-test failed
          - nf-test failed
(lint check is all green)
m
which version of nf-core tools are you using?
l
4.1.0
m
which version of nf-test? We manually parse the output of nf-test and if we don't get the expected output phrase we report it as failed. unfortunately this is a bit unstable depending on version and if it passes with 
nf-test test
you are good to go
l
nf-test 0.9.5 haven't tried with nf-test test yet, I'll do it
yeah tests pass both in nf-core tools and nf-test directly guess I'll try submitting for PR
👍🏻 1
j
I sometimes get it locally but actually the run is fine
No clue why but if there is no diff then normally just open PR
l
confirm-pass-nf-test fails on my PR though 🤔
j
Ah I see
Huh that's odd
l
Yeah 🫠 not sure what's happening
it's required, so does that mean the PR can't be merged until it passes? Because I can't figure out why it's not passing 🫠
m
Can you try to run it on a github codespace?
l
which part?
m
the failing test to see if it fails also there
l
identified the mistake (forgot to update the snapshot after implementing the changes from the review), now the checks are passing (though still "failing" locally)
3 Views
Open in Slack
PreviousNext
Powered by