Hi all, I have worked along with Claude to fix the...
# release-review-trading
s
Hi all, I have worked along with Claude to fix the failing tests for the nf-core/isoseq release. I discovered the conda lock file which solve the problem. I still one red download test, but it seems to be an artefact of previous templates. It would be very nice I could release the version before I finish writing the RNA Bioinformatics book chapter in September 🙏. I happy take code review! github.com/nf-core/isoseq/pull/62
👀 1
m
DEADLINE?
s
The chapter must be deliver for September , no exact date have been given.
m
ok, on it then
but only because it's you
💕 1
s
Thanks for your time ^^
m
Nice work
I have a couple of comments, but very minor
I am impressed that you managed to go from 2.14.1 to 4.1.0
No easy feat
s
I'm happy to read that 🙂 Until my recent commits, I mainly done the work without AI.^^ For the templates merges, I have done that along the time, so that was OK to handle 🙂 I'll have a look to your comments soon, I keep writing while I'm motivated! Thanks again for your time!
🎉 1
m
Some of them (about comments or indentation don't really need to be fixed, it's just it'll look nicer). The others are more important, mainly the specific conda lock profile, that I think is not really needed
s
That"s the one of the part I have done with Claude xD The problem is that conda dependencies resolving lands on different program versions from the singularity images which this lead to different md5sums. I'll have a look 😉
m
for me these conf/containers_*.config are all you should need
👍 1
something like this should do the trick hopefully:
nf-core pipelines lint --dir . --fix container_configs
with nf-core 4.1.0
s
OK I'll do that tomorrow and let you know !
s
Hi Maxime, when you have time, can we finish the review?
m
On it, thanks for the reminder
👍 1
s
It seems you are trying to sell me something xD Many thanks for your time!
🤣 1