Can I get a review on <github.com/nf-core/sarek/pu...
# release-review-trading
r
Can I get a review on github.com/nf-core/sarek/pull/2257. It looks huge at 449 files. Before you you walk away, it's so much because the modules are completed migrated to using topics and a lot of strict syntax fixes (Channel -> channel,
it
replacements etc). In terms of actual change we got: • Parabricks haplotypecaller • Varlociraptor/filterfdr • Bug fix for inputs and one for normlaizing vcfs • 3 template updates Because it's mostly module bumps, most of the files can also be ignored for review. I am doing the version bump ceremony now and running the full size tests to validate it all.
approved with comments 1
d
I'm working tomorrow, Wed, but then I'm on holiday for the rest of the week and can't approve until Monday.
r
thanks a lot! I'll focus on finishing your review tomorrow and then look at the things you flagged