2 DAYS OF LOOKING AT CODE, FINALLY FOUND THE BUG I...
# rants
s
2 DAYS OF LOOKING AT CODE, FINALLY FOUND THE BUG IN METHYLSEQ...I KNOW I SHOULD BE HAPPY ABOUT (& I AM) BUT I AM RANTING THAT IT TOOK ME SO LONG TO SPOT IT https://github.com/nf-core/methylseq/blob/54f823e102ef3d04077cc091a5ae435519f9923a/subworkflows/local/prepare_genome.nf#L51 (P.S: the bug was assigning wrong index ch for the aligner)
shakefist 4
s
oh, so should have been
ch_bwameth_index =
rather than
ch_bismark_index =
s
yup
p
ooh amazing - is this the bug that has been repeatedly reported for like, a year now? 😅
🤣 3
pikachu detective
s
looks like it
e
git blames it homer disappear
I'll write the tests as penance
p
phew
s
looks like another bug, the fasta_index ch creation was nested in the bwameth scope https://github.com/nf-core/methylseq/blob/master/subworkflows/local/prepare_genome.nf#L64-L70
p
Is fasta index needed with Bismark? I had a feeling that was only used in the bwameth workflow.
s
ya right looks like its used only by bwameth. Thanks for confirming
but think its best maybe to not nest it under bwameth in general for future use ?
🤷🏻‍♂️ 1
guess we can change it if required in future...will stick to bwameth for now