https://nf-co.re logo
Join Slack
Powered by
Hello, we would like to trade a review on <https:/...
# release-review-trading
c
Hello, we would like to trade a review on https://github.com/nf-core/pairgenomealign/pull/99, which is mostly 3.5.1 / topic channel upgrade…
✅ 1
j
@Charles Plessy this doesn't look like a release PR...?
If this will become the release review I will review it now 'in advance'
But really the way it should be is that every PRs going into 
dev
should be with a version of 
X.X.Xdev
Then just before you have a PR for solely bumping version
into 
dev
And then you open the fina lrelease pr 
dev
-> 
master
I'm confused now though because you should be getting linting failures atm
But you don't even have the comment bot comment with it 🤔
c
Got it. And thanks for the review. I removed 
dev
because it gave me lint failures saying that I should not have `dev`… In any case, we plan to make a release PR as soon as this PR is merged.
🤔 1
j
It should only complain about that if you are running with 
--release
was that the case?
c
j
Was ist initially opened against master/main maybe and then switched to dev after?
c
Ah yes bingo 🙂 Sorry for the noise!
j
No worries! Just wanted to understand! Can check everything properly when we get to the official pr
2 Views
Open in Slack
PreviousNext
Powered by