Can someone spot why lining fails here? <https://g...
# linting
t
m
you need to specify some output. it shouldn't fail that uggly, but if I print the linting failures before the crash, it reads :
Copy code
[('missing_emit', 'Missing emit statement: /*  There is not generated output  __init__.py:292
         files.', PosixPath('modules/nf-core/samtools/quickcheck/main.nf')), ('missing_emit', "Missing
         emit statement: The sole purpose of 'samtools quickcheck' is to return an error if the mapping
         file is malformatted.", PosixPath('modules/nf-core/samtools/quickcheck/main.nf')),
         ('missing_emit', 'Missing emit statement: The purpose in of the Nextflow process is to break the
         main workflow (by default) if the script returns a non-zero exit code.',
         PosixPath('modules/nf-core/samtools/quickcheck/main.nf')), ('missing_emit', 'Missing emit
         statement: The nf-core components guidelines
         (<https://nf-co.re/docs/guidelines/components/modules>) do not specify that there must be output
         files.', PosixPath('modules/nf-core/samtools/quickcheck/main.nf')), ('missing_emit', 'Missing
         emit statement: */', PosixPath('modules/nf-core/samtools/quickcheck/main.nf')), ('main_nf',
         'main_nf_meta_output', "'meta' map not emitted in output channel(s)",
         PosixPath('modules/nf-core/samtools/quickcheck/main.nf'))]
m
failure is due to multiline comment
😨 1
m
ah, this is a bug in linting, where we parse the comment incorreclty
party this 1
if you rewrite them with
//
in the start of each line, it should work
🤦‍♂️ 1
m
I would put the comments only in meta
t
Removing the multi-line comment actually fixed it. Thank you both so much
@mashehu just for me to learn: how did you catch the linting errors prior to the linter's crash ?
m
I added some debugging code inside nf-core tools 😬
t
That's another level of nf-core Kung-Fu. I'll just wait for the next release then 😉
👍🏻 1
👍 1
big shout-out to @Jim Downie for reviewing. thanks a lot!
extreme teamwork 2
🎉 1