Hey, we are hoping to get some external review of ...
# release-review-trading
c
Hey, we are hoping to get some external review of the first release of
nf-core/genomeqc
! github.com/nf-core/genomeqc/pull/227 Its a huge PR, as its kind of been delayed, with other projects taking over, but think it is definitely in decent shape, and we think it fulfils all the checklists. Very happy to review anyone elseโ€™s pipeline releases if helpful ๐Ÿ™‚
m
added a pseudo PR to make reviewing easier https://github.com/nf-core/genomeqc/pull/228
v
Hi Chris, I am planning on asking for a release review soon of a pipeline I have been working on for some time too that is also quite big. Maybe I can help review this one in return for some help on my one? My pipeline is for analysing RNA structure data: github.com/nf-core/proposals/issues/114 I will be transferring to nf-core and creating the PR for review probably within a week or two.
c
Hey Victoria, Great, very happy to do a review exchange. A week or two is good for us, if you are ready then. Maybe its helpful to have a zoom meeting when you are ready and we can go over our release PRs. Then go away and do the full review before meeting back?
v
Hi Chris, great! Yes, this sounds like a good idea - I'll try to get the pipeline ready for review asap and let you know ๐Ÿ™‚
โœ… 1
Hi @Chris Wyatt I have just created the PR for the first release of
nf-core/rnastructurome
๐ŸŽ‰ github.com/nf-core/rnastructurome/pull/5 Would you be free for a zoom meeting next week?
c
@Victoria Begley. Great to hear. Happy to meet next week, but may have to be Friday 24th any time (or Thursday 9-10am BST). As we are doing a nextflow/metagenomic training in Durham earlier in the week.
v
No problem, I can do Thursday or Friday. My email is begley@ebi.ac.uk if you'd like to send me a zoom link for this ๐Ÿ™‚
๐Ÿ‘ 1
Hi @Chris Wyatt just to let you know I finished reviewing your pipeline!
c
Great, thanks @Victoria Begley, we should be done by Thursday afternoon. Had a few other deadlines before. So hopefully we can discuss after, and/or continue on Github.
v
Perfect ๐Ÿ˜„
c
Code looks excellent so far, only very minor comments
๐Ÿฅณ 1