Looking for two reviewers for this small <#C062H82...
# release-review-trading
j
Looking for two reviewers for this small #C062H82UCRG release: https://github.com/nf-core/createtaxdb/pull/198 • One new module (Centrifuger) • Small module update (KrakenUniq) • Template update
@Ammar Aziz;)
m
happy to help out
n
Happy to trade for the upcoming genomeassembler release 😄
j
How big is it...
n
Huge
j
damn it
fiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiine
n
But the hugest part of it was already reviewed by 2 people, so hopefully you can just trust them
j
note that I am actually moving country over the next month though
n
Leaving germany after we failed the world cup again?
j
So I can't guarantee how fast I will get to it (depends how long cleaning/fixing the apartment takes)
Leaving germany after we failed the world cup again?
No, since the entire Straßenbahn network in Leipzig has been dead the entire week because all the tracks broke because their shitty Asphalt-based 'repairs' of gaps between the rails and tarmarc melted and was squirting out of the gulleys like ice cream during the heat dome last week
(or my partner got a contract that is >2 years in Spain 😅 )
n
Both seem like good reasons to relocate
😆 1
j
But anyway sure I'll trade 👍
n
If someone reviews my open PR today, I will prepare the release PR today, if not I will be off for 2 weeks
👍 1
j
Ooorrr coudl I trade the two open PRs for my release? 😬
n
One of the two PRs has already 2 reviews
j
DAMN IT
I can't escape can I 😉
n
but, sure, the other one would be appreciated 😄
ALso fine to trade for the other one, I will anyway need to go reviewer shopping for the release
m
@James Fellows Yates LGTM, I would avoid using params in the subworkflows, but that can be fixed later
❤️ 1
j
HYeah, I need to do a big overhaul of all my pipelines in that regard
Reviewed the HiC one @Niklas Schandry 1
🙌 1
a
Too fast for me! Great to see