More modular and easy control on which tool should...
# seqinspector
m
More modular and easy control on which tool should run on subsampled data: https://github.com/nf-core/seqinspector/pull/243 @Pontus Höjer I will continue working on the multiQC report to make this more prominent
p
I was testing this out but got this issue
Copy code
% nextflow run . -profile docker,test --outdir outdir --sample_size 50

 N E X T F L O W   ~  version 26.04.4

Launching `./main.nf` [cheesy_noether] revision: a69a7e8c01

ERROR ~ Cannot compare java.lang.String with value '50' and java.lang.Integer with value '0'

 -- Check script 'subworkflows/local/utils_nfcore_seqinspector_pipeline/main.nf' at line: 377 or see '.nextflow.log' file for more details
m
Oh
of course
let me fix that in the PR
Fix incoming
Thanks for finding all these issues on the CLI
the tools_bundle null I would not have encounter it at all
good to go, please let me know if it works as you would expect
p
Now it works
I think the warning is good but maybe it should be at the start of the report to make it clear for the reader. Also maybe Its just me but “warning” is maybe a bit severe, what about “Subsample notice”?
m
It should have been on top 🫠
I am on it
updated
Thanks Pontus
@Pontus Höjer does it feel better now?
p
Hi thanks for working on this, will try it out now and get back to you
m
Thanks
p
The report looks good now 👌 I added a few other comment under the PR.
m
Thanks