Template update, modules and a few bug fixes: https://github.com/nf-core/metatdenovo/pull/444 (I'm afraid not as easy as my recent phyloplace release.) I have limited time this week, but happy to trade if you can wait until next week. My PR is certainly not urgent either.

I am planning a release update next week, I will ping you 🙂

Perfect! Thanks!

@Daniel Lundin #C02K5GX2W93 is still looking for s econd if you wuould like to trade?

Absolutely

❤️

I was a bit afraid of that question. And I don't have a better answer than the first virtue. On a more serious note, I actually looked through this during this cycle but I didn't come any further than this. I will keep thinking about it

mmmm, how desperate are yo ufor this to be released? 😬

Quite urgent I'd say. There is an important bug fix in this and I have major work for #C01U1E95JQ5 planned that I'd like to start soon

Ok, then I'll allow this but I'm going to make an issue blocking the next release until this is fixed 😉 It looks like you've spent a long time updating all these local modules for somethign that should have just been

nf-core modules update

and done. It's meaning this is quite a painful review for me too 😅 (normally I can ignore most nf-core moduel files)

Thanks

Approved with a few minor comments

thanks! Will turn to #C02K5GX2W93 after my meeting, so around noon

The said issue: https://github.com/nf-core/metatdenovo/issues/445 But like I said you can proceed with 1.4 for now

Good that you remind me about

DIAMOND_BLASTP

. I remember I did a local because at the time I couldn't get

nf-core modules patch

to work. It turned out it stumbled on Vim temporary files. Since then I've patched many modules successfully.