*REVIEWERS WANTED for hazardous journey* Small, b...
# release-review-trading
m
REVIEWERS WANTED for hazardous journey Small, bitter cold, long nights of staring at 268 changed files, constant danger of being lost in #CGFUX04HZcode, safe release doubtful, honour and recognition in case of success. Seeking brave soul to review https://github.com/nf-core/sarek/pull/2168: the Release 3.9.0. 32 squashed commits deep, from MuSE timestamps to varlociraptor scenario fixes, from parabricks CRAM_TO_BAM to nf-slack plugin migration, from strict syntax fixes to an animated metromap. The changelog alone could keep you warm through winter. No prior release review experience required. Must be willing to look at code for a while. Those with a fondness for CHANGELOG.md preferred. Apply within. The ice is thinning.
🥾 1
🧊 1
sarek polish 2
extreme teamwork 1
✅ 1
r
To soften the blow: a decent chunk of those are strict syntax and/or nf-core/modules changes
e
If only there was a debloat release first eh @Maxime Garcia? XD
🤣 1
j
@Maxime Garcia trade for tuesday review of sarek?
m
@Famke Bäuerle @Rike Hanssen is that ok for you?
👍 1
j
Teo fell asleep early and my supervisor hadn't read my revisions manuscript so looking now for you all ❤️
m
I have approved already
Oh sorry, you meant the Sarek pr
j
Yes
Did you want me to look at something elsE?
m
Thanks 🙇
No Sarek is more important, I can call in more favors for playing around in my other things
👍 1
j
Finito
m
Thanks
r
@Jonathan Manning could you reapprove? I went through the reviews and either adressed them or deferred them to new issues please
m
@James Fellows Yates could you re-aprove too: https://github.com/nf-core/sarek/pull/2168
We aim to release today
GHA is on fire, so tests are failing, but no worries, all works
j
You want a re-review or just approval? The original is still there
m
aproval
j
image.png
m
ok, nevermind then
THANKS
and sorry