Hi, I'm updating the `ichorcna` module to topic ve...
# modules
l
Hi, I'm updating the
ichorcna
module to topic versions. However this module calls in R seqInfo(genome_build) and this function try to download a file on UCSC. This download then fail on the github's CI. What should I do ? https://github.com/nf-core/modules/pull/11829
shakefist 2
What I don't understand is that at first it did work for singularity and docker in the CI https://github.com/nf-core/modules/actions/runs/26772064983/job/78914080261
Should I rewrite the whole function in a template to remove the seqInfo call and pass it with a chrom_size table (downloaded beforehand) ?
s
I would move on and focus on other modules personally
I definitely encountered this issue myself ~3 years ago
with ichor
l
But, this would left a module without the topic ! 🥲 Or should we simply force push with a message saying this module doesn't work without internet access ?
s
Luca may have encountered this more recently too @Einar
the CI has internet access
l
If the CI has internet access, this is really strange. A simple
Copy code
download.file(
    "<https://hgdownload.soe.ucsc.edu/goldenPath/hg19/database/chromInfo.txt.gz>",
    tempfile()
)
gives an error, while locally it works
s
I can download it on my macbook, but not from my server
l
That's strange...
s
yeah, I get the same
l
But even thought the
Seqinfo(genome)
function calls
getOption("UCSC.goldenPath.url")
, setting
options(UCSC.goldenPath.url = "<https://hgdownload2.soe.ucsc.edu/goldenPath>")
still leads to
cannot open URL '<https://hgdownload.soe.ucsc.edu/goldenPath/hg19/database/chromInfo.txt.gz>'
... What the hell 🫠
s
shared a GIF
spaghetti code
how did you try the options?
l
I've just added at the start for now.
s
yeah, didn't work on my server either
l
Yeah, to fix it we need to load the library first, then update the options.
s
that still didn't work for me
l
Strange, this did work in the CI by doing
Copy code
library("GenomeInfoDb")
options(UCSC.goldenPath.url = "<https://hgdownload2.soe.ucsc.edu/goldenPath>")
Seqinfo(genome="hg19")
https://github.com/nf-core/modules/pull/11829
s
ah, I didn't load GenomeInfoDb first
just loading ichor wasn't sufficient
e
Uargh
I saw that just now, sorry
(This happened when I was moving....)
It's solved now?
I see it is. Thanks for figuring it out!
s
Yeah, Louis has done some magic
e
Weird that I didn't notice it, SAMURAI uses it verbatim I think
s
the server was accessible from some locations, just not all