<#CE8SSJV3N> ready for another release and seeking...
# release-review-trading
j
#CE8SSJV3N ready for another release and seeking reviewers https://github.com/nf-core/rnaseq/pull/1838. Actually a small one, but the template update is inflating changed file numbers. Happy to swap.
Trade you @Evangelos Karatzas?
m
I think @Ram might be looking for someone for #C025UH66DA8
r
I’ve already secured two reviewers for raredisease, but if anyone else would like to take a look as well, I’d really appreciate it. And I’ll happily return the favor by reviewing your next five releases 😛 😄 The PR looks massive at first glance, but most of the changes are from module updates, plus the addition of subworkflow tests, configs, and snapshot files, which inflated the diff quite a bit. 😅
e
Can do! yes @Jonathan Manning!
j
OK awesome, can look at #C084HP11VPF in a bit 🙂
🙌 1
f
i can have a look 🙂 here
j
Thanks! Do you need one Famke?
m
We will need a Sarek one
f
here: https://github.com/nf-core/bamtofastq/pull/140 🙂 (still missing the version bump away from dev but ready otherwise)
👍 1
j
@Evangelos Karatzas my AI reviewer found some points, you'll see that review pop up first. I'll also see if my human eyes spot anything 🙂
f
alos for #C050TCYSCFM i am debating whether it should be a 2.2.1 or 2.3.0 because there are no new features but we are bumping nextflow quite a bit
j
I always do a minor bump unless it's exclusively bugfixes
(so 2.3.0 for me, but your call)
f
That was a quick one - I added a few comments but it looks good in my eyes!
j
Thank you! I'm just about to send you my first AI review pass, will also try to look manually to see if anything was missed
🐕 1
👍 1
@Evangelos Karatzas approved yours with comments- just one important fix
@Famke Bäuerle human eyes didn't spot anything extra, given you my approval assuming you'll address the bug
We will need a Sarek one
When @Maxime Garcia?
e
I'll get to yours in a bit, thanks!
thankyou 1
m
> We will need a Sarek one
When @Maxime Garcia?
https://github.com/nf-core/sarek/pull/2168 Not too much in a hurry I'd say, we have people that owe us already