But just one person opinions, <!here> any thoughts...
# team-maintainers
j
But just one person opinions, <!here> any thoughts on disucssion on thread above? Talking about two 'options' to fix something that is currently breaking modules PRs
p
Not sure we should have merged this without figuring out a solution first..
100 rainbow 3
j
Which is why I'm more aggressively pinging on behalf of @Jonathan Manning and @Nicolas Vannieuwkerke
j
1 DHP for Nicolas for merging with errors (which I just realised he did shakefist ).
(sorry, reflexive cultural reference: DHP = deducted house point, punishment in UK schools, for any non-Brits-of-a-certain-age)
j
tenor_gif7736402895919125951.gif
n
Feel free to revert if this is too big of a nuisance. I severely misjudged the impact of that. Will work on a solution tomorrow
Sorry guys 😅
p
It's all good - you're pushing towards strict syntax adherence, which arguably we should have been doing some months ago already..
My preference is to merge + bump to 26.04 now, then also hopefully can get the Nextflow error patched in a backported 25.10 release. Then we should be covered in both cases.. Does that work?
s
I'm happy to bump to 26.04 now
but bumping just the linting to 26.04 is also reasonable
👍🏻 1
👍 1
n
I'll do that first thing tomorrow then! Thanks everyone
👍 2
I reverted all but linting. Can I get one more approval?
✅ 1