https://nf-co.re logo
Join Slack
Powered by
Uhhh I might have found a possible last minute bug...
# tools
j
Uhhh I might have found a possible last minute bug @mashehu 😬 , waiting for the test to confirm before cofirming
m
link?
j
(in 
.github/actions/workflows/download_pipeline.yml
)
image.png
m
uff, yes
j
This line
m
wait, how does your 
.nf-core.yml
look like?
j
m
and that worked no?
j
Yes
image.png
m
j
Is it because the directory name is repeated/
m
looking into it
j
Copy code
pip install     nf-core==${{ steps.read_yml.outputs['nf_core_version'] }}
uv tool install nf-core==${{ steps.read_yml.outputs['nf_core_version'] }}
m
yeah, don't want to add a setup-uv step to install only one tool.
my guess is something is wrong with the path where it looks for the file.
can you try it with this lines in the action: https://github.com/nf-core/tools/pull/4251/changes
j
OK
In the download action?
(I assume)
Ah righty eah
Running
Still not
image.png
Still can't find the 
.nf-core/yml
thing it seems
Does it make a difference that in the nf-test runs the path is 
_work
not just 
work
?
(lunch now, but feel free to push changes)
m
figured it out. we don't have a checkout step there, that's why we don't have an 
.nf-core.yaml
facepalm
m
Nice catch
m
j
And this won't mess with the download rest itself though?
It won't accidently allow the checkout repo to be executed?
m
nope, it just pulls it in to get this one file 🙂
👍 1
j
OK I'm back, will try it out
@mashehu I confirm it workeD! TEsts running now!
🎉 1
thanks 1
m
can i get a review here then please https://github.com/nf-core/tools/pull/4251
✅ 1
2 Views
Open in Slack
PreviousNext
Powered by