https://nf-co.re logo
Join Slack
Powered by
It looks like `nf-tools 4.0.0` has new, stricter r...
# tools
g
It looks like 
nf-tools 4.0.0
has new, stricter requirements on the container paths for modules. It used to give a warning if the container wasn't on 
<http://quay.io|quay.io>
but now it's counted as a failure. Is there more documentation on this? The link it provided in the error message is broken (can submit a bug if you want). Thank you!
m
yes, sorry, the API docs broke with this release, working on a fix. The relevant PR is https://github.com/nf-core/tools/pull/4209
for an explanation of the change: https://github.com/nf-core/modules/pull/11251
but we didn't change that we only require quay.io I think. do you have an example PR?
g
Yeah I could be interpreting the message incorrectly. But here is the PR. I got a bunch of lint errors all of the sudden and it's because of the container path.
quick look 1
image.png
m
ah, yes, actually we kind of require quay or wave atm. can you try it locally or in google code spaces with 
nf-core m lint --registry <http://vcr.io/nvidia/clara/|vcr.io/nvidia/clara/>
to see if it is really that
g
Yeah I have this all setup locally
Okay that actually passed with no errors, just a warning
m
what warning do you get?
g
The same one I'm used to seeing:
m
okay, I will try to get a patch in tomorrow, wrote things into an issue for now: https://github.com/nf-core/tools/issues/4243
g
Thank you! A list of allowable registries would be perfect for my case. Any of these solutions will work for me.
m
i am also tending towards a list of allowed registries because parsing nextflow configs is always a bit of a pain
🎉 3
g
@mashehu do you have any updates on the patch? Thank you!
m
Sorry, got down prioritized because of a new template updates and bug fixes. Should be able to do it next week. If you need me to force merge a PR tell me.
g
That's okay. I have another thing blocking this PR so that timeline is fine. Thank you so much.
Hi @mashehu I wanted to check in on this registry patch. My PR is ready to merge once this is resolved. If there's any way I can help, let me know. Thank you!
Hey @mashehu, sorry to ping here again. I have a couple of PRs now that are blocked by this issue. Can I help to get this fix prioritized? Thank you!
m
Hi, sorry, for not getting back to you before, but I guess we have a bad overlap with timezones. anyway, I have now a PR ready that should get in merged soon: https://github.com/nf-core/tools/pull/4282 but I am also happy to force merge your PR until then if you want
g
Thank you! Yeah I'm in Boston and I think you're in Sweden? Thank you for helping me with this. If your PR will be merged some time this week then I can wait
👍🏻 1
@Maxime Garcia I see that Matthias is on vacation, is there someone who can help to unblock this?
m
I can have a look at it first things tomorrow. I'm already in afterwork mode here unfortunately
g
That's okay! Thank you. It can wait until tomorrow.
🙏 1
2 Views
Open in Slack
PreviousNext
Powered by