Funcprofiler 1.0.0; this one is a doozy: <https://...
# release-review-trading
n
Funcprofiler 1.0.0; this one is a doozy: https://github.com/nf-core/funcprofiler/pull/40 There are a myriad of improvements to be made for 1.1.0 (test_full, more flexibility with output formats, etc) but I think 1.0.0 is a good starting point. Happy to trade reviews!
j
Please note
test_full
is required for first release 😬
(also 156 filesis SMALL 😆 )
I'm happy to take this one <!subteam^S016E36N7TQ>
🙏🏻 1
Might take a week or so though @Nick Waters if that is OK for you
n
thanks so much! I'll try to get the
test_full
datasets tested in the meantime.
👍 1
j
n
@Jonas S sure! I just had a look through and all the changes look good to my untrained eye. Made a comment about the env variable on the test failure. If there is anything specific you’d like a closer look at, or you want me to run something on my hardware, let me know! I might have an immunopeptidomics project coming up, so I might have more relevant contributions then 🤞
j
Cool stuff! Let me know when you need input/help. Thanks for looking at the PR, I think Jonathan gave already a thorough review 🙂 I’ll try to have a look at yours today!
j
@Nick Waters I've finished my review, unfortunately there is a lot to do before first releaes
🙏 1
I've made sure to go through everything however, so you have a full list of things todo
j
Hi @Nick Waters I just found time to review. Quite some work to do still, specifically with the container registry. Hope it helps!
n
Thank you both!