https://nf-co.re logo
Join Slack
Powered by
REVIEWS GIVEN THROUGH MULTIPLE 'ADD COMMENT' AND N...
# rants
j
REVIEWS GIVEN THROUGH MULTIPLE 'ADD COMMENT' AND NOT ALL ADDED TO A SINGLE 'START REVIEW' shakefist shakefist shakefist shakefist
🤣 2
homer disappear 1
shakefist 3
I've been told to blame @Maxime Garcia by @Nicolas Vannieuwkerke 😬
m
I do appreciate having the comments coming one at a time rather than having a full tsunami
j
Eh? But why?
You get hundreds of notifications
party this 1
And what do you mean about a full tsunami?
j
MOOD
j
You feel me @Jim Downie?
j
I do! Though I’ll confess to being guilty of it myself
m
I usually don't have time to do a full review in 1 sitting, so I might do a small quick review with a small tsunami wave
I can improve my way of doing if you'd prefer
j
But you can do multiuple smaller reviews?
this 1
m
I will pay attention
j
❤️
(anyway, sorry to throw you on the firing line 😆 - Nicolas reviewed in the way you prefer, and got caught in the cross fire)
m
No problem. I do appreciate it to be honest
❤️ 1
n
Yeah I'll keep that in mind next time I review something for you 😛
But I love blaming Maxime evil laugh
😆 2
maxime 1
p
Related: clicking "apply suggestion" on every single comment, resulting in loads and loads of commits. Instead of doing them in a single batch commit.
100 rainbow 5
shared a GIF
j
Related: clicking "apply suggestion" on every single comment, resulting in loads and loads of commits. Instead of doing them in a single batch commit.
big mood also, but to be fair the add to batch functionality is only available on the review page so isn't immediately obvious 😓
100 rainbow 1
party this 2
p
Yeah, that's a UI bug imho, they should at least direct you in that direction
s
I don't understand why the batch functionality isn't available from the normal page 🤷
Oh it does tell you
m
I've been advocating for that for years
s
image.png
👀 1
p
Fair enough! I stand corrected.
j
Out of curiosity how do y'all have GitHub notifications set up? Currently I receive many emails every day telling me about each and every thing that happens on anything I’m subscribed to
Which may not be optimal
s
Oh, I don't get emails
I just get notifications if I look at GitHub
p
I get some emails, but they go into a filtered gmail folder where they automatically get marked as read and I never look at them lolsob
j
I should probably fix this... I feel like it's default settings though cause I never set this up this way
m
disable expect for some repo
I am on almost every slack channel here though
n
I receive emails and filter through them at some point but those are not a priority for me
j
Out of curiosity how do y'all have GitHub notifications set up? Currently I receive many emails every day telling me about each and every thing that happens on anything I’m subscribed to
I used to have it for everything, then turned it off except for run failures. I do have github mobile app notifications for reviews etc though
(thus the complaint)
I think I did that because the control over notifications on the app was easier
p
Yeah I have the app and get push notifications there if anyone 
@ewels
pings me
👍 2
I'm also working towards having daily Claude summaries of my emails / slack, and that includes all github notifications. So in theory it should be able to spot anything that I am needed for.
m
no emails, but https://gitify.io/ to quickly scan and handle notifications.
j
oh noice
Open in Slack
PreviousNext
Powered by