Hi! I saw that a big PR is curretly reviewed and it really looks amazing! 🙂 However, I think that adding more E2E tests would make the pipeline much more stable and reproducible. I won't be able to work on it until next May / June, but if you want, I made Hi-C test files adapted to the genome you are using in the pipeline: https://github.com/OlivierCoen/nf-genome-assembler/tree/main/tests/test_data/hic_short_reads/a_thaliana Hope it helps!

Thanks for your suggestions, would you maybe like to formally review this? I had solicited Jim Downie originally, but he is going on parental leave..?

you're welcome 🙂 actually I'm going to be pretty busy in the following days, but I can try to find some time next week

I am currently largely blocked by my remaining work, so a review is not super urgent

you're still adding features?

But of course I would need a second review to move this forward

Oh ok... Yes it takes lots of time

But I would also prefer to have both reviews once I get back to this, so I can adress them and hopefully be done. Adding tests for HiC is of course something I would do in this PR

actually I'm currently working hard for the first release of #C07Q8HNU4FK, but if I manage to do it quite quickly, I could even help you make some tests. But I can't guarantee that

That would be highly appreciated, since I will not be able to do any work on this at least until mid April, there is no rush