Can someone suggest if im moving in the right dire...
# modules
p
Can someone suggest if im moving in the right direction - i've found a module with a hardcoded parameter that isnt adjustable via
task.ext.args
https://github.com/nf-core/modules/issues/10308 I can open a PR to fix this but im wondering how we communicate these changes, that a commandline option that was previously applied, will now no longer be used. Is it up to the consumer of the module to carefully vet incoming changes when they update their modules?
s
It looks like this parameter is required for the tool to run, but has been hardcoded to one option yes. See https://nf-co.re/docs/guidelines/components/modules#required-val-channel-inputs
If that is the case, it'll just fail if you remove it
But yes, it is up to the consumer of the module to check the incoming changes
p
Ok, if understand correctly
Copy code
regtools junctions extract \\
        $args \\
        -s XS \\                   <-- existing hard-coded option to remove
        -o ${prefix}.junc \\
        $bam
add a channel input
Copy code
val(strand_specificity) // XS, use XS tags provided by aligner; RF, first-strand; FR, second-strand;
and a default value
Copy code
def strand = strand_specificity ?: 'XS'
and use the value
Copy code
regtools junctions extract \\
        $args \\
        -s ${strand} \\                   <-- add this
        -o ${prefix}.junc \\
        $bam
s
That sounds like a reasonable plan.