https://nf-co.re logo
Join Slack
Powered by
Final steps :checkered_flag: I'm currently adding ...
# hadge
l
Final steps 🏁 I'm currently adding the final features to hadge (see remaining issues with prio:high and prio:normal). As soon as I'm done with that, what are the steps to bring the pipeline to nf-core? @Nico Trummer, maybe you can help us with that?
🥳 1
l
I can ping the right people when it's ready for transfer. Then we transfer it and create a PR against main to create a first release. This will go through a big review and then we should be done
https://github.com/theislab/hadge/issues/83
This would only be a local module, right? I don't think this needs to be a whole nf-core module and other pipelines in nf-core already do this I think
n
Having local modules is fine, only modules that can be useful for people that build their own pipelines should be in #CJRH30T6V. Also it is fine to have some modules local first, and move them to #CJRH30T6V later
So it seems the new implementation is close to feature-complete now. Before requesting the 1.0 release review, I would like to look through the entire pipeline another time and flag everything that needs to be improved. However, this does not need to happen before we move the pipeline to nf-core. What order do you prefer @Lukas Heumos: 1. Wait until feature-complete, move to nf-core, have an internal release review, then the public review 2. Wait until feature-complete, have an internal release review, move to nf-core, instantly request the release review From an nf-core standpoint both are fine, theoretically one can already move a pipeline to nf-core if minimal functionality is available.
For the move of the pipeline to nf-core, a new workflow has recently been introduced via #C09H6NYHR9T
l
I'm fine with option 1.
👍 1
l
This would only be a local module, right?
Yes, just a local module!
👍 1
Thanks, @Nico Trummer and @Lukas Heumos! I'll let you know when I'm done!
It seems I have exceeded my free Codepace core hours at GitHub, right? I also have some bills in my settings now. Never had this before. Then I need to wait for next month, won't I? Or do you have any other ideas?
n
I think there are some options you have: • Get GitHub Pro for your account if you don't have it already (free for students, but processing your request might take a few days) • Get another GitHub account so that it starts counting from zero Also about billing: This should be disabled by default but if you set up a payment method you kind of "consented" that they can bill you
l
Thank you, Nico! I immediately requested a GitHub Pro for students. I hope it won't take too long!
I was a bit surprised because I never set up a payment method.
At least, they stopped it at around 1.5 $ 😅
Woo-hoo, I've opened the final-features PR. 🥳 Although it isn't entirely review-ready, I have already added some comments where you can help us out, @Nico Trummer.
All tests are passing, and the PR is ready for review. party dino @Lukas Heumos , could you take a look at the documentation (
README.md
, 
docs/output.md
, 
docs/usage.md
)? Also, what affiliation should we use for Fabiola now? @Nico Trummer, could you give it another look from a nf-core/nextflow perspective? You can take your time, I won’t be able to make any changes before Friday since I have an exam that day. After the review, we can move the pipeline to nf-core. nf core
🎉 1
l
Let's just use her old affiliation aka Helmholtz for now. Her problem if she doesn't answer
👍 1
Open in Slack
PreviousNext
Powered by