Gene summary and donor match PR The next steps to ...
# hadge
l
Gene summary and donor match PR The next steps to bring hadge to nf-core have been completed. However, I still need some help with the current PR: 1. A new nf-core version is available. When I run
nf-core pipelines sync
and then
git merge TEMPLATE
, I get several merge conflicts again. @Nico Trummer, last time you mentioned you could take care of that. Would you have time to do it again? If not, could you let me know who might be able to help, or should I give it a try myself? 2. I’ll also need someone to review my PR. @Lukas Heumos mentioned at the last meeting that he could take care of that. @Nico Trummer, would you also like (or need) to review it from a nf-core perspective? Thanks a lot! 🙏
n
I can do the template update after work today
Also feel free to request my review on the second PR
l
Thanks, Nico! That would be great.
l
Please request reviews when you need them. Otherwise I don't know whether things are ready or not
l
Thanks, Lukas. I will request a review! Not yet fully ready for reviewing.
l
The tests aren't running through though, are they? They time out no?
Ah okay. Thanks!
l
Yeah, tests still fail. We need to merge the souporcell PR first and update nf-core.
👍 1
I hope this resolves the queued "Run nf-test". 🙏
n
I merged the souporcell PR yesterday, also I finished the template update today and merged it into
dev
. Then I merged
dev
into the
aggregate-genetic-new
. I also noticed the reason why the tests where not running: This was because nf-core switched to self-hosted github actions runners with the previous template update, which are not available outside of the nf-core organization. I switched back to github-hosted runners to make the tests work in our case. After moving to nf-core we have to revert this.
To make the PR ready to merge, @Luis Heinzlmeier please update the souporcell module and think about the review I added concerning
fasta
l
@Nico Trummer thank you very much!