A community effort to collect a curated set of analysis pipelines built using Nextflow.

nf-core

Hello all, I am looking for two reviewers for big release :smile: Happy to reciprocate now or in future <https://github.com/nf-core/variantbenchmarking/pull/253>

I can take a look next Wednesday if no one has done it by then. Please remind me if necessary :stuck_out_tongue:

Also calling <@UEM37TBAR> to see who's next on the list of core team reviewers :wink:

I just had a brief look and I did not see from the Changelog why this is a 2.0.0 and not a 1.3.0 :slightly_smiling_face:

I thought it is suitable to have version 2 now, as I added a number of new features and I dont have much more to add for a while.. but of course it is debatable :D

Ah ok because I thought we only bump the major version when we introduce breaking changes :)

<https://nf-co.re/docs/guidelines/pipelines/requirements/semantic_versioning#major-release-eg-143-to-200>

I can make the changes breaking old :stuck_out_tongue: just joking.. I donno i can also bump version 1.4. Since I want to submit paper draft with this I think I wanted to have a nice version

Just pointing at the guidelines here I think this is not a 2.0.0 but a 1.4.0 :sweat_smile: I'll have a more in depth look after lunch!

&gt; I can make the changes breaking
:rolling_on_the_floor_laughing:

I am going back to 1.4.0 :smile: I was doubting my proud versioning either :D

Just came here to express my joy at folks following the semver guidelines we wrote! :nf-core-party:

:smile: it is my pleasure :laughing:
can someone also approve this for going back to 1.4.0 <https://github.com/nf-core/variantbenchmarking/pull/255>

Btw <@U03CKGEU3LZ> I am definitely not on the hook for this one

1. This isn't a first release :wink:
2. According to our tracking board,  Edmun, Fran, Jose, Júlia, Yourself, Phil nor Sateesh have done their reviews in the first round :wink:

Yeah I was not assigning you :wink: I was asking who was next on the review list :stuck_out_tongue:

(and I have done several first release reviews in the last months :open_mouth:)

Oh I should totally learn how ot read :laughing: