Looking for one review for taxprofiler: <https://g...
# release-review-tradings
Sofia Stamouli
11/21/2025, 9:30 AMLooking for one review for taxprofiler: https://github.com/nf-core/taxprofiler/pull/661
Template merge and two bug fixes. Happy to reciprocate 🙂
👀 1
m
Maxime Garcia
11/21/2025, 10:10 AMlooking good
Maxime Garcia
11/21/2025, 10:10 AMI think there was an issue with the TEMPLATE merge
Maxime Garcia
11/21/2025, 10:11 AMapart from that nothing much to say
Maxime Garcia
11/21/2025, 10:12 AMI noticed that you started to move some logic away from the main workflow, and I like this
Maxime Garcia
11/21/2025, 10:12 AMI would continue down this line, and avoid using params at this level as well
Maxime Garcia
11/21/2025, 10:12 AMNice job
2 Views