I dislike the spacing of import statements: ```inc...
# random
a
I dislike the spacing of import statements:
Copy code
include { MULTIQC                                   } from '../modules/nf-core/multiqc/main'
include { paramsSummaryMap                          } from 'plugin/nf-schema'
please dont shoot me
a
But really it should be:
Copy code
include { MULTIQC          } from '../modules/nf-core/multiqc/main'
include { paramsSummaryMap } from 'plugin/nf-schema'
And its more readable imo than:
Copy code
include { MULTIQC } from '../modules/nf-core/multiqc/main'
include { paramsSummaryMap } from 'plugin/nf-schema'
πŸ’― 1
p
This is a very confusing thread to read on mobile πŸ˜…
βž• 2
πŸ˜‚ 7
a
Slack could really use an option to disable wrapping on code blocks
πŸ’― 1
m
I have auto format on save that put everything as Arthur showed
a
What I didnt show was a bunch of other imports that force that crazy style of spacing. I prefer what Arthur mentioned:
Copy code
include { MULTIQC } from '../modules/nf-core/multiqc/main'
include { paramsSummaryMap } from 'plugin/nf-schema'
Is optimal imo.
m
I see
I don't care much for all the space to be honest, and I'd rather see the
}
nicely align. meow love Harshil Alignment forever meow love But I see your point.
a
Out of interest why is the alignment of the ending
}
important to you?
a
Aligning the
}
makes it much easier to see what’s being imported at a glance imo
party this 3
βž• 1
Visually, it unclutters the line and the filepath is generally much less relevant to me
❀️ 1
a
This to me makes more visual sense but I might be crazy:
Copy code
include { MULTIQC }                                   from '../modules/nf-core/multiqc/main'
include { paramsSummaryMap }                          from 'plugin/nf-schema'
a
It also has the benefit of aligning the filepaths and that does allow one to quickly scan and see what is from the modules vs subworklows, local vs nf-core
Braces are ugly, the further they are from my vision the better
πŸ‘ 1
a
I really like them personally
s
you can break up the section into some shorter and some longer imports though
πŸ‘ 2